Skip to content

LONDON | ITP-MAY-25 | TEWODROS BEKERE | SPRINT-3 | Slide-Show #733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

LONDON | ITP-MAY-25 | TEWODROS BEKERE | SPRINT-3 | Slide-Show #733

wants to merge 2 commits into from

Conversation

iteddy16
Copy link

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

  • Fixed and added more buttons and functionality to work properly, and added CSS to the HTML to make it better visualized to the user.

Briefly explain your PR.

  • It displays an image from the object manually and automatically with a command from the buttons assigned to it.

Questions

Ask any questions you have for your reviewer.

@iteddy16 iteddy16 added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 31, 2025
@iteddy16 iteddy16 changed the title LONDON | ITP-MAY-25 | TEWODROS TEME | SPRINT-3 | Slide-Show LONDON | ITP-MAY-25 | TEWODROS BEKERE | SPRINT-3 | Slide-Show Aug 1, 2025
day-lee
day-lee reviewed Aug 4, 2025
View reviewed changes
Sprint-3/slideshow/slideshow.js
}

function AutoPlay(direction) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done for creating a function to avoid repetition 👍

day-lee
day-lee reviewed Aug 4, 2025
View reviewed changes
Sprint-3/slideshow/slideshow.js
Comment on lines +20 to +21
updateImage();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best practice to keep the consistent indentation!

@day-lee
Copy link

day-lee commented Aug 4, 2025 •
edited
Loading

Code looks good! However, it doesn't pass the tests. Can you have a look and make sure to pass all the tests?

@day-lee day-lee added Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Complete Volunteer to add when work is complete and all review comments have been addressed. labels Aug 4, 2025
@iteddy16
Copy link
Author

iteddy16 commented Aug 5, 2025

Code looks good! However, it doesn't pass the tests. Can you have a look and make sure to pass all the tests?

@day-lee, thank you for your feedback. I didn't understand the final feedback regarding the test pass if you mean the lighthouse test. If it is, I checked the availability and it scored 100 Here is the screenshot.
Screenshot 2025-08-05 at 16 23 49

@day-lee
Copy link

day-lee commented Aug 6, 2025

Hi @iteddy16. I meant the slideshow.test.js using npm test in the ../slideshow directory. I guess the test is optional tho as the readme docment doesn't mention about it. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@day-lee day-lee day-lee left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 3 Assigned during Sprint 3 of this module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iteddy16 @day-lee